Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error in frustum_random_point_feature_noise.py. #2372

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
+14 −3
Draft

Fix an error in frustum_random_point_feature_noise.py. #2372

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8749b27
Fix an error in frustum_random_point_feature_noise.py.
yangustc07 Mar 6, 2024
cf5165a
In some models, this produces the following error:
yangustc07 Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions keras_cv/layers/preprocessing_3d/waymo/frustum_random_point_feature_noise.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Copyright 2022 Waymo LLC.
#
# Licensed under the terms in https://github.com/keras-team/keras-cv/blob/master/keras_cv/layers/preprocessing_3d/waymo/LICENSE # noqa: E501
import logging

import tensorflow as tf

Expand Down Expand Up @@ -98,9 +99,17 @@ def get_random_transformation(self, point_clouds, **kwargs):
# frustum.
valid_points = point_clouds[0, :, POINTCLOUD_LABEL_INDEX] > 0
num_valid_points = tf.math.reduce_sum(tf.cast(valid_points, tf.int32))
randomly_select_point_index = tf.random.uniform(
(), minval=0, maxval=num_valid_points, dtype=tf.int32
)
try:
randomly_select_point_index = tf.random.uniform(
(), minval=0, maxval=maxval, dtype=tf.int32
)
except tf.errors.InvalidArgumentError:
logging.error(
"Skipping frustum random point noise augmentation: No valid "
"point is found."
)
return {}

randomly_select_frustum_center = tf.boolean_mask(
point_clouds[0], valid_points, axis=0
)[randomly_select_point_index, :POINTCLOUD_LABEL_INDEX]
Expand Down Expand Up @@ -144,6 +153,8 @@ def get_random_transformation(self, point_clouds, **kwargs):
def augment_point_clouds_bounding_boxes(
self, point_clouds, bounding_boxes, transformation, **kwargs
):
if "point_noise" not in transformation:
return (point_clouds, bounding_boxes)
point_noise = transformation["point_noise"]

# Do not add noise to points that are protected by setting the
Expand Down