Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Make Backbone parent classes to allow handling all subclass presets and support extensions #2418

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

smitlg
Copy link
Contributor

@smitlg smitlg commented Apr 16, 2024

What does this PR do?

This PR makes supports easy tree extensions and allows access to all subclass presets to a parent class.

Who can review?

cc @divyashreepathihalli

@smitlg smitlg marked this pull request as draft April 16, 2024 06:39
@smitlg smitlg force-pushed the expose_base_classes branch from adb5ea4 to a94af37 Compare April 16, 2024 06:42
@smitlg
Copy link
Contributor Author

smitlg commented Apr 16, 2024

@divyashreepathihalli

I found one local failure:

FAILED keras_cv/models/object_detection/retinanet/retinanet_test.py::RetinaNetTest::test_tf_dataset_data_generator - ValueError: Preset has type `ResNetBackbone` which is not a a subclass of calling class `ResNet50Backbone`...

Debugging into this, I see that kaggle config json has registered_name: "keras_cv>ResNetBackbone". To make this PR work, we need to update the config to have ResNet50Backbone.

@divyashreepathihalli
Copy link
Collaborator

@divyashreepathihalli

I found one local failure:

FAILED keras_cv/models/object_detection/retinanet/retinanet_test.py::RetinaNetTest::test_tf_dataset_data_generator - ValueError: Preset has type `ResNetBackbone` which is not a a subclass of calling class `ResNet50Backbone`...

Debugging into this, I see that kaggle config json has registered_name: "keras_cv>ResNetBackbone". To make this PR work, we need to update the config to have ResNet50Backbone.

What you see on kaggle is the standard format that is followed for all models in KerasCV and KerasNLP. That will not be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants