Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenVINO backend] Support numpy.empty #21010

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

arkhamHack
Copy link

@arkhamHack arkhamHack commented Mar 10, 2025

Hi, @rkazants, could you review this pr? This would close openvinotoolkit/openvino#29357

Copy link

google-cla bot commented Mar 10, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.43%. Comparing base (3820c0f) to head (98b25f1).

Files with missing lines Patch % Lines
keras/src/backend/openvino/numpy.py 55.55% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21010      +/-   ##
==========================================
- Coverage   82.44%   82.43%   -0.01%     
==========================================
  Files         562      562              
  Lines       53643    53652       +9     
  Branches     8321     8324       +3     
==========================================
+ Hits        44225    44230       +5     
- Misses       7380     7382       +2     
- Partials     2038     2040       +2     
Flag Coverage Δ
keras 82.25% <55.55%> (-0.01%) ⬇️
keras-jax 63.72% <0.00%> (-0.02%) ⬇️
keras-numpy 58.68% <0.00%> (-0.01%) ⬇️
keras-openvino 32.64% <55.55%> (+<0.01%) ⬆️
keras-tensorflow 64.17% <0.00%> (-0.02%) ⬇️
keras-torch 63.76% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arkhamHack arkhamHack force-pushed the empty_support_openvino branch from b0baa9e to 11cd909 Compare March 11, 2025 01:34
@arkhamHack
Copy link
Author

arkhamHack commented Mar 11, 2025

Also, do let me know if any improvements needed regarding the logic, and what changes might be needed to increase code coverage. @rkazants
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Good First Issue][Keras 3 OpenVINO Backend]: Support numpy.empty operation
3 participants