This repository was archived by the owner on Aug 12, 2021. It is now read-only.
A couple crucial issues with the requests#7
Open
zeelot wants to merge 2 commits intokerkness:masterfrom
synapsestudios:master
Open
A couple crucial issues with the requests#7zeelot wants to merge 2 commits intokerkness:masterfrom synapsestudios:master
zeelot wants to merge 2 commits intokerkness:masterfrom
synapsestudios:master
Conversation
zeelot
commented
Nov 17, 2010
- The bootstrap was loading modules before log and config classes were attached, this caused fatal errors in some of my modules that had init.php files. I've switched the order of these in the default bootstrap.
- You were assuming the Kohana request would always return a string. I've made sure the response is valid as long as it implements a __toString() method like View and Kostache both do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.