Skip to content

bpf: Make sure all tail call callers use cgroup storage if the owner does #10418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kernel-patches-daemon-bpf wants to merge 2 commits into from
Closed

bpf: Make sure all tail call callers use cgroup storage if the owner does #10418

kernel-patches-daemon-bpf wants to merge 2 commits into from

Conversation

@kernel-patches-daemon-bpf
Copy link

@kernel-patches-daemon-bpf kernel-patches-daemon-bpf bot commented Dec 3, 2025

Pull request for series with
subject: bpf: Make sure all tail call callers use cgroup storage if the owner does
version: 3
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1030226

@kernel-patches-daemon-bpf
Copy link
Author

kernel-patches-daemon-bpf bot commented Dec 3, 2025

Upstream branch: 30f0920
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1030226
version: 3

@kernel-patches-daemon-bpf
Copy link
Author

kernel-patches-daemon-bpf bot commented Dec 4, 2025

Upstream branch: 30f0920
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1030226
version: 3

@kernel-patches-daemon-bpf
Copy link
Author

kernel-patches-daemon-bpf bot commented Dec 4, 2025

Upstream branch: 8f7aa3d
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1030226
version: 3

@kernel-patches-daemon-bpf
Copy link
Author

kernel-patches-daemon-bpf bot commented Dec 4, 2025

Upstream branch: 835a507
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1030226
version: 3

@kernel-patches-daemon-bpf
Copy link
Author

kernel-patches-daemon-bpf bot commented Dec 4, 2025

Upstream branch: 861111b
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1030226
version: 3

@kernel-patches-daemon-bpf
Copy link
Author

kernel-patches-daemon-bpf bot commented Dec 4, 2025

Upstream branch: 861111b
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1030226
version: 3

@kernel-patches-daemon-bpf
Copy link
Author

kernel-patches-daemon-bpf bot commented Dec 4, 2025

Upstream branch: 861111b
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1030226
version: 3

@kernel-patches-daemon-bpf
Copy link
Author

kernel-patches-daemon-bpf bot commented Dec 10, 2025

Upstream branch: 861111b
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1030226
version: 3

@kernel-patches-daemon-bpf
Copy link
Author

kernel-patches-daemon-bpf bot commented Dec 10, 2025

Upstream branch: 189e5de
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1030226
version: 3

@ameryhung
bpf: Make sure all tail call callers use cgroup storage if the owner …
ebc08c4 
…does

Mitigate a possible NULL pointer dereference in bpf_get_local_storage()
by requiring all callers to use cgroup storage if the owner does.

Cgroup storage is allocated lazily when attaching a cgroup bpf program.
With tail call, it is possible for a callee BPF program to see a NULL
storage pointer if the caller prorgam does not use cgroup storage.

Reported-by: Yinhao Hu <[email protected]>
Reported-by: Kaiyan Mei <[email protected]>
Reported-by: Dongliang Mu <[email protected]>
Closes: https://lore.kernel.org/bpf/[email protected]/
Signed-off-by: Amery Hung <[email protected]>
@ameryhung
selftests/bpf: Test tail call when cgroup storage is used
a0da018 
Make sure that if the owner of a program array map uses cgroup storage,
(1) all callers must use cgroup storage and (2) the cgroup storage map
used by all callers and callees must be the owner's cgroup storage map.

Signed-off-by: Amery Hung <[email protected]>
@kernel-patches-daemon-bpf
Copy link
Author

kernel-patches-daemon-bpf bot commented Dec 10, 2025

Upstream branch: 297c3fb
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1030226
version: 3

@kernel-patches-daemon-bpf
Copy link
Author

kernel-patches-daemon-bpf bot commented Dec 10, 2025

At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1030226 expired. Closing PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bpf changes-requested V3-ci-pass V3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ameryhung