bpf: Fix truncated dmabuf iterator reads #10423
Open
+91
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: 30f0920 |
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf_base
branch
from
4f34c49 to
bc9f2f4
Compare
Author
|
Upstream branch: 30f0920 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1030279=>bpf
branch
from
a8e9f36 to
6931c6b
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf_base
branch
from
bc9f2f4 to
d81819b
Compare
Author
|
Upstream branch: 8f7aa3d |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1030279=>bpf
branch
from
6931c6b to
7977aab
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf_base
branch
from
d81819b to
4a41073
Compare
Author
|
Upstream branch: 835a507 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1030279=>bpf
branch
from
7977aab to
7cf5b07
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf_base
branch
from
4a41073 to
892a959
Compare
Author
|
Upstream branch: 861111b |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1030279=>bpf
branch
from
7cf5b07 to
55333dc
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf_base
branch
from
892a959 to
f33722a
Compare
Author
|
Upstream branch: 861111b |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1030279=>bpf
branch
from
55333dc to
b37b182
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf_base
branch
from
f33722a to
6627cb2
Compare
If there is a large number (hundreds) of dmabufs allocated, the text output generated from dmabuf_iter_seq_show can exceed common user buffer sizes (e.g. PAGE_SIZE) necessitating multiple start/stop cycles to iterate through all dmabufs. However the dmabuf iterator currently returns NULL in dmabuf_iter_seq_start for all non-zero pos values, which results in the truncation of the output before all dmabufs are handled. After dma_buf_iter_begin / dma_buf_iter_next, the refcount of the buffer is elevated so that the BPF iterator program can run without holding any locks. When a stop occurs, instead of immediately dropping the reference on the buffer, stash a pointer to the buffer in seq->priv until either start is called or the iterator is released. This also enables the resumption of iteration without first walking through the list of dmabufs based on the pos value. Fixes: 76ea955 ("bpf: Add dmabuf iterator") Signed-off-by: T.J. Mercier <[email protected]>
If many dmabufs are present, reads of the dmabuf iterator can be truncated at PAGE_SIZE or user buffer size boundaries before the fix in "selftests/bpf: Add test for open coded dmabuf_iter". Add a test to confirm truncation does not occur. Signed-off-by: T.J. Mercier <[email protected]>
Author
|
Upstream branch: 861111b |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1030279=>bpf
branch
from
b37b182 to
ae6d2a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: Fix truncated dmabuf iterator reads
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1030279