Stacktrace test ci #9914
Closed
Stacktrace test ci #9914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using bpf_program__attach_kprobe_multi_opts on ARM64 to hook a BPF program that contains the bpf_get_stackid function, the BPF program fails to obtain the stack trace and returns -EFAULT. This is because ftrace_partial_regs omits the configuration of the pstate register, leaving pstate at the default value of 0. When get_perf_callchain executes, it uses user_mode(regs) to determine whether it is in kernel mode. This leads to a misjudgment that the code is in user mode, so perf_callchain_kernel is not executed and the function returns directly. As a result, trace->nr becomes 0, and finally -EFAULT is returned. Therefore, the assignment of the pstate register is added here. Fixes: b9b55c8 ("tracing: Add ftrace_partial_regs() for converting ftrace_regs to pt_regs") Closes: https://lore.kernel.org/bpf/[email protected]/ Signed-off-by: Feng Yang <[email protected]>
This reverts commit 83f44ae. Acked-by: Song Liu <[email protected]> Signed-off-by: Jiri Olsa <[email protected]>
Signed-off-by: Jiri Olsa <[email protected]>
…p_tp Signed-off-by: Jiri Olsa <[email protected]>
olsajiri
force-pushed
the
stacktrace_test_ci
branch
2 times, most recently
from
37d5560 to
fe5c502
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
5558007 to
55c7461
Compare
olsajiri
force-pushed
the
stacktrace_test_ci
branch
3 times, most recently
from
4c21ee1 to
e08c683
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
2 times, most recently
from
034e8d9 to
bd1a434
Compare
Adding stacktrace test for kprobe[_multi] probes. Signed-off-by: Jiri Olsa <[email protected]> --- test for arm fix posted separately in here: https://lore.kernel.org/bpf/[email protected]/
Signed-off-by: Jiri Olsa <[email protected]>
Adding stacktrace test for uprobe[_multi] probes. Signed-off-by: Jiri Olsa <[email protected]>
olsajiri
force-pushed
the
stacktrace_test_ci
branch
from
e08c683 to
ec923f3
Compare
olsajiri
force-pushed
the
stacktrace_test_ci
branch
from
c0ceb80 to
62280db
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
11 times, most recently
from
c85a7ce to
a4b455f
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
a4b455f to
4038f13
Compare
|
Automatically cleaning up stale PR; feel free to reopen if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.