Merged
Conversation
There was a problem hiding this comment.
Performed full review of 000a938...1f86286
Analysis
- Moving from side-effect based cleanup to explicit state management could introduce transition issues if not all code paths are updated to recognize the new "failed" state marker.
- The PR may not address potential race conditions between the cancellation signal handling and the normal operation flow.
- Changing the cancellation semantics could affect downstream components that may have been relying on the previous browser deletion behavior.
Tip
⚡ Quick Actions
This review was generated by Mesa.
Actions:
Slash Commands:
/review- Request a full code review/review latest- Review only changes since the last review/describe- Generate PR description. This will update the PR body or issue comment depending on your configuration/help- Get help with Mesa commands and configuration options
1 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings
rgarcia
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Handles
Control+Cduring aninvokecommand to gracefully terminate the remote session by updating its status tofailed.Why we made these changes
Previously, interrupting an
invokecommand withControl+Cwould only terminate the local CLI process, leaving the remote session running. This could lead to orphaned resources and unexpected behavior. This change ensures that when a user cancels an operation, the remote session is properly cleaned up.What changed?
cmd/invoke.go:SIGINT(Control+C).invocationIDis available immediately for the cancellation handler.Description generated by Mesa. Update settings