Add version column and filtering to invocation history command#21
Merged
hiroTamada merged 1 commit intomainfrom Sep 29, 2025
Merged
Conversation
There was a problem hiding this comment.
Performed full review of e796437...06e4e20
Analysis
Based on the provided analysis, there don't appear to be any significant architectural issues with this pull request. The analysis is entirely positive, noting that the implementation follows established patterns, properly integrates with the SDK, provides a good user experience, and maintains backward compatibility.
Since you specifically asked for potential issues and the analysis doesn't mention any concerns, I can only infer some potential minor considerations:
- The addition of a new column (Version) between existing columns (Action and Status) might require UI/display adjustments to ensure proper formatting across different terminal sizes.
- The implementation relies on the kernel-go-sdk v0.11.5, which might create a dependency on specific SDK behaviors that could change in future versions.
Tip
⚡ Quick Actions
This review was generated by Mesa.
Actions:
Slash Commands:
/review- Request a full code review/review latest- Review only changes since the last review/describe- Generate PR description. This will update the PR body or issue comment depending on your configuration/help- Get help with Mesa commands and configuration options
3 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings
rgarcia
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description:
Summary
This PR enhances the
kernel invoke historycommand by adding support for displaying and filtering invocations by version.Changes
--versionflag to filter invocations by versionNew Features
--versionflagUsage Examples
Implementation Details
Versionfield from the SDK'sInvocationListResponsestructVersionfilter parameter inInvocationListParamsDependencies
github.com/onkernel/kernel-go-sdkfrom v0.11.4 to v0.11.5TL;DR
This PR enhances the
kernel invoke historycommand by adding a "Version" column to the output and a--versionflag for filtering.Why we made these changes
To allow users to easily find and inspect invocations for a specific application version, which is useful for debugging and tracking behavior across different releases.
What changed?
cmd/invoke.go: Added the--versionflag for filtering and a "Version" column to the history table display.go.mod&go.sum: Updated thegithub.com/onkernel/kernel-go-sdkdependency from v0.11.4 to v0.11.5 to support the new API parameter.Validation
The changes were validated by running the command with different flag combinations:
kernel invoke historydisplays the new "Version" column.kernel invoke history --version v1.2.3correctly filters the results.kernel invoke history --app myapp --version v1.2.3filters by both app and version.Description generated by Mesa. Update settings