Support configurable TOTP in credential commands - #277
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
akxue
approved these changes
Oct 1, 2026
akxue
left a comment
Contributor
There was a problem hiding this comment.
looks good! comments are around help text and making the new totp flags a bit clearer. additionally, as a note, get/create don't output the new totp settings
cmd/credentials.go:496-497— oncredentials update --help,--totp-digitsand--totp-periodshow(6)/(30), which reads like leaving them off sets 6/30. the API actually keeps whatever's already stored when you rotate a base32 secret. maybe register these with default 0 so the default isn't printed, and add a line saying omitted settings are kept? (on create the help also prints(default 6) (6)since cobra appends the default automatically)cmd/credentials.go:185-206— if--totp-secretis an otpauth:// URI that has its own digits/algorithm/period, the API uses the URI's values and silently ignores the--totp-*flags. i think we should warn here rather than rejectcmd/credentials.go:165-175,cmd/credentials.go:268-278— note: get/create only printHas TOTP Secret: Yes, so there's no way to confirm which algorithm/digits/period got stored. the sdk response includes these now, so they could be added as rows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checks
go test ./...passed locally.