CLI: Update SDK to c026e806a1bdffd330b0f533d5f132d7d9b0e5aa and add new commands/flags - #278
Open
kernel-internal[bot] wants to merge 3 commits into
Open
kernel-internal[bot] wants to merge 3 commits into
kernel-internal[bot] wants to merge 3 commits into
Conversation
SDK version bump only. A full enumeration of SDK methods vs CLI commands found no coverage gaps (config-registry endpoints are x-cli-skip). Tested: go build ./... (no new commands/flags to smoke test) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
- Bump github.com/kernel/kernel-go-sdk to 10c4031082d73b41180adeb54a722f89341907ff - Add --totp-algorithm, --totp-digits, --totp-period to `kernel credentials create` and `kernel credentials update` (CreateCredentialRequestParam / UpdateCredentialRequestParam TotpAlgorithm, TotpDigits, TotpPeriod) - Show TOTP algorithm/digits/period in credentials get/create output Tested: credentials create --totp-secret --totp-algorithm sha256 --totp-digits 8 --totp-period 60 (8-digit code returned, metadata shown in get), credentials totp-code, credentials update --totp-secret --totp-algorithm SHA512 --totp-digits 7 (verified in get -o json), invalid --totp-algorithm rejected, otpauth:// URI params take precedence over explicit flags, credentials delete cleanup. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kernel-internal
Bot
changed the title
Bumps kernel-go-sdk to v0.116.0 (c026e806a1bd). The SDK changes since 10c4031082d7 are release metadata only. A full enumeration of SDK methods against CLI commands found no coverage gaps. Config-registry endpoints are x-cli-skip. Tested: go build ./..., go test ./... (SDK version bump only, no new commands/flags) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kernel-internal
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Go SDK to c026e806a1bdffd330b0f533d5f132d7d9b0e5aa and adds CLI commands/flags for new SDK methods.
SDK Update
Coverage Analysis
This PR was generated by performing a full enumeration of SDK methods and CLI commands. Config-registry endpoints are marked
x-cli-skipand are intentionally not covered.The latest bump from 10c4031082d7 to c026e806a1bd (v0.116.0) only changes SDK release metadata, so it adds no new gaps. The flags below come from the earlier commit on this branch.
New Commands
New Flags
kernel credentials create --totp-algorithmforCreateCredentialRequestParam.TotpAlgorithm(SHA1/SHA256/SHA512, case-insensitive)kernel credentials create --totp-digitsforCreateCredentialRequestParam.TotpDigitskernel credentials create --totp-periodforCreateCredentialRequestParam.TotpPeriodkernel credentials update --totp-algorithmforUpdateCredentialRequestParam.TotpAlgorithmkernel credentials update --totp-digitsforUpdateCredentialRequestParam.TotpDigitskernel credentials update --totp-periodforUpdateCredentialRequestParam.TotpPeriodcredentials getandcredentials createnow show TOTP Algorithm, Digits and Period when a TOTP secret is configured. The--totp-secrethelp text now says it also acceptsotpauth://URIs.Testing
Run against the live API in the earlier commit:
gettotp-code: worksget -o jsonotpauth://URI parameters win over the explicit flagsAfter the v0.116.0 bump:
go build ./...andgo test ./...pass.Triggered by: kernel/kernel-go-sdk@c026e80
Reviewer: @masnwilliams
🤖 Generated with Claude Code
Note
Medium Risk
Changes how stored 2FA credentials are created and updated; incorrect TOTP parameters could break login flows, though algorithm validation and SDK behavior limit exposure.
Overview
Bumps kernel-go-sdk to v0.116.0 and wires new credential TOTP options through the CLI.
credentials createandcredentials updategain--totp-algorithm(SHA1/SHA256/SHA512, validated vianormalizeTotpAlgorithm),--totp-digits, and--totp-period, passed to the SDK only when set (Int64Flag+Changed()for numeric flags).--totp-secrethelp now documents otpauth:// URIs;totp-codehelp no longer assumes 6-digit codes.credentials getand create success tables insert TOTP algorithm, digits, and period rows when a secret exists (credentialTotpRows). Adds a small unit test for algorithm normalization.Reviewed by Cursor Bugbot for commit ea4aa73. Bugbot is set up for automated code reviews on this repo. Configure here.