fix(client): add anti-echo guard for video syncing#166
Merged
rgarcia merged 2 commits intokernel:mainfrom Feb 27, 2026
Merged
Conversation
Contributor
|
thanks @AbdulRashidReshamwala! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an anti-echo guard to prevent play/pause event spams.
Note
Medium Risk
Touches client-side video play/pause state synchronization; a small logic change could still cause playback state to get stuck or miss updates on some browsers (notably Safari).
Overview
Prevents play/pause “echo” loops between the Vuex
playingwatcher and the<video>element by introducing anisVideoSyncingguard.When native
playing/pauseevents fire, the component temporarily marks itself as syncing and defers clearing the flag to the next tick, avoiding Safari timing races where events can precedevideo.pausedupdates.Written by Cursor Bugbot for commit ee912e3. This will update automatically on new commits. Configure here.