Conversation
There was a problem hiding this comment.
What Changed
This PR updates the images/chromium-headful/run-docker.sh script to use an absolute path for the Chromium flags file. The FLAGS_FILE variable is now prepended with $(pwd)/ to ensure it's correctly resolved when running Docker locally, fixing a pathing issue.
Risks / Concerns
This is a low-risk change that improves the local development experience. The author noted that this was not tested with unikernels, which is a minor concern to keep in mind, but the change itself is robust. Great work on this fix!
1 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings
Sayan-
approved these changes
Jul 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running Docker locally requires an absolute path for
.tmp/chromium/flags"TL;DR
Updated
run-docker.shto use an absolute path for Chromium flags, fixing local Docker execution.Why we made these changes
Local Docker setup for Chromium failed because the flags file was not found without an absolute path.
What changed?
FLAGS_FILEvariable to prepend$(pwd)/, ensuring it's always an absolute path relative to the current working directory.Validation