Merged
Conversation
There was a problem hiding this comment.
What Changed
This PR enhances the uk-check-stats.sh script to include additional network-related metrics. The script's output now includes 'NConns', 'NReqs', 'NQueued', and 'NTotal', providing a more comprehensive view of instance performance alongside the existing CPU and memory stats.
Risks / Concerns
The changes are straightforward and well-contained within the script. The implementation looks solid. Great work on enhancing the observability of our instances!
1 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings
heyglassy
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
link
TL;DR
Enhanced
uk-check-stats.shto display new network-related instance metrics.Why we made these changes
To provide more comprehensive insights into instance performance, specifically network connection and request statistics, which are crucial for monitoring and debugging.
What changed?
shared/uk-check-stats.sh: Updated to collect and displayinstance_nconns,instance_nreqs,instance_nqueued, andinstance_ntotalmetrics. The script's output header and data display were adjusted to incorporate these new columns.Validation