Merged
Conversation
rgarcia
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
As I spent more time with this lib I noticed a few things I wasn't a huge fan of (no concurrency, ~incomplete compression, some surprises with deadlining). Opt'ing to swap over to the coder/websocket library that I've used successfully in prod for ~years
Testing
Built docker + unikernel images. Tested the unikernel images against the wip test suite
TL;DR
Replaced the
gorilla/websocketlibrary withcoder/websocketfor handling Chrome DevTools connections.Why we made these changes
The previous library had limitations regarding concurrency, compression, and connection deadlining. The
coder/websocketlibrary is a more robust, production-proven alternative that resolves these issues.What changed?
go.modandgo.sumto swap the websocket libraries.server/lib/devtoolsproxy/proxy.goto use the newcoder/websocketAPI for accepting, dialing, and managing connections.server/lib/devtoolsproxy/proxy_test.goto align with the new implementation.echo -nwithprintfinserver/cmd/api/api/process_test.gofor better test compatibility.Description generated by Mesa. Update settings