Feat: add section build details #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfjnascimento
approved these changes
Jul 22, 2024
| const sections = useMemo( | ||
| () => | ||
| subsections?.map(subsection => ( | ||
| <Subsection key={''} infos={subsection.infos} /> |
| return ( | ||
| <div className="flex flex-col gap-4 text-dimGray"> | ||
| <div className="flex flex-col gap-2"> | ||
| <span className="text-sm">{description}</span> |
There was a problem hiding this comment.
Nit: this is usually called eyebrow
| () => | ||
| infos.map(info => ( | ||
| <LinkWithIcon | ||
| key={''} |
mari1912
force-pushed
the
feat/add-section-build-details
branch
from
599d811 to
d7ca3f8
Compare
- add subsection - add section - add section group - fix link icon font size
- add route to build details page - add section group with mocked data
mari1912
force-pushed
the
feat/add-section-build-details
branch
from
d7ca3f8 to
cfddb2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test it
pnpm run devin dashboardhttp://localhost/build/aaaaorhttp://localhost:5173/build/aaaaVisual reference