Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test table in build details wrong redirect #686

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

murilx
Copy link
Contributor

@murilx murilx commented Dec 16, 2024

When interacting with the tests table in the Build Details page it would incorrectly redirect because navigate was not receiving the state. By passing the state to navigate this cease to happen.

Closes #681

@murilx murilx self-assigned this Dec 17, 2024
@murilx murilx force-pushed the fix/redirect-build-details-test-table branch from cc6b45b to 8398e39 Compare December 17, 2024 20:47
When interacting with the tests table in the Build Details page it would
incorrectly redirect because navigate was not receiving the state. By
passing the state to navigate this cease to happen.

Closes #681
@murilx murilx force-pushed the fix/redirect-build-details-test-table branch from c057326 to 9bbd4ba Compare December 20, 2024 12:59
@murilx murilx marked this pull request as ready for review December 20, 2024 13:00
Copy link
Collaborator

@WilsonNet WilsonNet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug seems to be fixed on my tests

Copy link
Collaborator

@MarceloRobert MarceloRobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked on my tests, seems straightforward

@murilx murilx merged commit fd0baa2 into main Dec 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants