Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(hardware): Difference between hardware listing and hardware details tests counts #701

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Feat(hardware): Difference between hardware listing and hardware details tests counts #701

merged 2 commits into from
Dec 20, 2024

Conversation

Francisco2002
Copy link
Collaborator

@Francisco2002 Francisco2002 commented Dec 19, 2024 •
edited
Loading

  • Add validation of repeated tests in hardware listing and hardware details
  • Treat NULL tests status

How to test

Close of #687

@Francisco2002 Francisco2002 marked this pull request as ready for review December 19, 2024 18:11
MarceloRobert
MarceloRobert approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@MarceloRobert MarceloRobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working well, just a nit comment

backend/kernelCI_app/views/hardwareDetailsView.py Outdated Show resolved Hide resolved
@Francisco2002 Francisco2002 force-pushed the fix/hardware-tests-counts branch from b27feeb to c7b3864 Compare December 20, 2024 12:13
murilx
murilx approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@murilx murilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Francisco2002 Francisco2002 force-pushed the fix/hardware-tests-counts branch from c7b3864 to 0ae065c Compare December 20, 2024 12:58
@Francisco2002 Francisco2002 merged commit 258cc2f into main Dec 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarceloRobert MarceloRobert MarceloRobert approved these changes

@murilx murilx murilx approved these changes

Assignees

@Francisco2002 Francisco2002

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Francisco2002 @murilx @MarceloRobert