-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: issue details page #707
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murilx
reviewed
Dec 20, 2024
MarceloRobert
force-pushed
the
feat/issue-details-page
branch
from
December 20, 2024 18:59
35ef4f0
to
846d204
Compare
Comment on lines
26
to
31
query = Issues.objects.values(*issue_fields).filter( | ||
id=issue_id, version=version | ||
) | ||
if len(query) == 0: | ||
return None | ||
return query[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
query = Issues.objects.values(*issue_fields).filter( | |
id=issue_id, version=version | |
) | |
if len(query) == 0: | |
return None | |
return query[0] | |
issue = Issues.objects.values(*issue_fields).filter( | |
id=issue_id, version=version | |
).first() | |
return issue |
MarceloRobert
force-pushed
the
feat/issue-details-page
branch
from
December 20, 2024 19:51
1504999
to
8f75ef1
Compare
MarceloRobert
force-pushed
the
feat/issue-details-page
branch
from
December 20, 2024 19:58
8f75ef1
to
f2d0bc9
Compare
murilx
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked well on my tests
Francisco2002
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an issueDetails endpoint and page with basic information
For now there is no navigation from other places in the frontend, so you'll need to access the urls manually
Also adds a condition to hide misc/files sections with empty objects
How to test
Get an
issue_id
and itsversion
and accesslocalhost:5173/issue/<issue_id>/version/<version>
and see the dataExamples:
http://localhost:5173/issue/maestro:26cab82e27e6b4a7e883e14b72220126b0206e4e/version/0
http://localhost:5173/issue/redhat:issue_1000/version/1669126978
Part of #591
Closes #704