Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: issue details page #707

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Feat: issue details page #707

merged 3 commits into from
Dec 20, 2024

Conversation

MarceloRobert
Copy link
Collaborator

@MarceloRobert MarceloRobert commented Dec 20, 2024

Adds an issueDetails endpoint and page with basic information
For now there is no navigation from other places in the frontend, so you'll need to access the urls manually

Also adds a condition to hide misc/files sections with empty objects

How to test

Get an issue_id and its version and access localhost:5173/issue/<issue_id>/version/<version> and see the data

Examples:
http://localhost:5173/issue/maestro:26cab82e27e6b4a7e883e14b72220126b0206e4e/version/0
http://localhost:5173/issue/redhat:issue_1000/version/1669126978

Part of #591
Closes #704

@MarceloRobert MarceloRobert changed the title Feat/issue details page Feat: issue details page Dec 20, 2024
@MarceloRobert MarceloRobert self-assigned this Dec 20, 2024
@MarceloRobert MarceloRobert force-pushed the feat/issue-details-page branch from 35ef4f0 to 846d204 Compare December 20, 2024 18:59
Comment on lines 26 to 31
query = Issues.objects.values(*issue_fields).filter(
id=issue_id, version=version
)
if len(query) == 0:
return None
return query[0]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
query = Issues.objects.values(*issue_fields).filter(
id=issue_id, version=version
)
if len(query) == 0:
return None
return query[0]
issue = Issues.objects.values(*issue_fields).filter(
id=issue_id, version=version
).first()
return issue

@MarceloRobert MarceloRobert force-pushed the feat/issue-details-page branch from 1504999 to 8f75ef1 Compare December 20, 2024 19:51
@MarceloRobert MarceloRobert force-pushed the feat/issue-details-page branch from 8f75ef1 to f2d0bc9 Compare December 20, 2024 19:58
Copy link
Contributor

@murilx murilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked well on my tests

@MarceloRobert MarceloRobert merged commit 844cb44 into main Dec 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IssueDetails: basic information
3 participants