feat(improvements): some minor improvements #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilsonNet
changed the title
WilsonNet
commented
Dec 23, 2024
Comment on lines
27
to
30
| const selectedItemClassName = | ||
| 'items-center hover:text-sky-500 w-full flex pl-5 py-4 cursor-pointer text-sky-500 bg-black border-l-4 border-sky-500'; | ||
| const notSelectedItemClassName = | ||
| 'items-center hover:text-sky-500 w-full flex pl-5 py-4 cursor-pointer text-white'; |
There was a problem hiding this comment.
have a baseClass variable for this
- Added `selected` prop to `NavLink` component to handle selected state - Updated `SideMenuItem` to use `NavLink` with `selected` prop - Removed redundant class names from `SideMenu` and `SideMenuItem` - Added `overflow-x-auto` to main content div in `__root.tsx`
WilsonNet
force-pushed
the
fix/accarini-patch
branch
from
e9bf479 to
8b7a98e
Compare
|
this was made by accarini and I submitted the PR and approved it |
murilx
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selectedprop toNavLinkcomponent to handle selected stateSideMenuItemto useNavLinkwithselectedpropSideMenuandSideMenuItemoverflow-x-autoto main content div in__root.tsx