-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show 'NULL' instead of nothing in status col #716
Conversation
da6bb5d
to
2bdccbc
Compare
@@ -131,7 +131,7 @@ export function BootsTable({ | |||
id: e.id, | |||
path: e.path, | |||
startTime: e.startTime, | |||
status: e.status, | |||
status: e.status ?? 'NULL', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put it on a constant
@@ -103,7 +103,7 @@ export function TestsTable({ | |||
duration: e.duration?.toString() ?? '', | |||
path: e.path, | |||
start_time: e.startTime, | |||
status: e.status, | |||
status: e.status ?? 'NULL', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto about constant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worked on my tests, just a minor comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!!
0583a80
to
2da0433
Compare
2da0433
to
310421e
Compare
After further research, apparently the problem only existed in the boots table in hardware details. The can be seem in this page Tests table showing 'NULL' status correctly, this page Boots table showing 'NULL' status correctly in the build table code in
src/components/BuildsTable/DefaultBuildsColumn.tsx
(since I couldn't find a tree or hardware that had Build with null status)Here an example of the bug happening in the boots table for hardware details
This happens because in the TreeDetailsView there's already a process ensuring that
record["test_status"] = "NULL"
if status is null/None in the database, and HardwareDetailsView does not have the same processing being done.Closes #714
Visual reference
Before
After