feat: change hardware priority in tests table #877

murilx · 2025-02-03T20:26:26Z

Show platform first and enviroment_compatible in the hover if it exists. Show only environment_compatible if platform is undefined
Add platforms to hardware column in the Issue Details tests table
Add platforms to hardware column in the Build Details tests table

How to test

Go to a tree details page and verify that the hardware priority is working correctly (to ensure that the tooltip is working you can filter for a hardware and check if the tooltip shows)
Do the same in a build details page. In this case you can open one of the tests and check if the platform is the one showing in the table and if the tooltip is correctly showing the environment_compatible (field "hardware" in test details) ou showing nothing if hardware is "Unknown"
Do the same in an issue details page. To quickly find an issue details page with tests you can go to a boots tab with issues and open one of the issues there.

Closes #864

WilsonNet · 2025-02-04T16:02:42Z

backend/kernelCI_app/typeModels/buildDetails.py

@@ -46,6 +47,7 @@ class BuildTestItem(BaseModel):
    path: Test__Path
    start_time: Test__StartTime
    environment_compatible: Test__EnvironmentCompatible
+    misc: Test__EnvironmentMisc = Field(alias="environment_misc")


I'm not so confident on this alias since there is a misc column in the database, that may cause confusion

This field name was a kind of "old" implementation I believe I did (not really a wise idea to call it 'misc' in retrospect) so I had to change this in other places of the code as well. I did test to check if everything was still working (ran all of the requests scripts and also navigated on the application) but I don't exclude the idea that some new bug might be created from this change, so please test the application in general if possible as well.

I also initially changed this for test-related items only. There's a misc in build items that we need to verify if comes from "build__misc" database field and if that's the case I don't see a problem with keeping it as only misc

WilsonNet · 2025-02-04T16:03:31Z

backend/kernelCI_app/typeModels/issueDetails.py

@@ -62,6 +63,7 @@ class IssueTestItem(BaseModel):
    environment_compatible: Test__EnvironmentCompatible = Field(
        alias="test__environment_compatible"
    )
+    misc: Test__EnvironmentMisc = Field(alias="test__environment_misc")


ditto about the alias

answered in the comment above

WilsonNet · 2025-02-04T16:05:09Z

dashboard/src/components/Table/TooltipHardware.tsx

-    return hardwares
-      ? hardwares.map(hardware => (
+    return shouldHaveTooltip
+      ? hardwares.slice(1).map(hardware => (


nit: magic number

WilsonNet · 2025-02-04T16:13:11Z

dashboard/src/utils/table.ts

+  const miscArray: (string | undefined)[] = [misc?.platform];
+  const envArray = environment_compatible ?? [environment_compatible];
+  return miscArray?.concat(envArray).filter(i => i !== undefined && i !== null);


I personally would do something like

Suggested change

const miscArray: (string | undefined)[] = [misc?.platform];

const envArray = environment_compatible ?? [environment_compatible];

return miscArray?.concat(envArray).filter(i => i !== undefined && i !== null);

const miscArray: string[] = misc?.platform ?? [];

const envArray: string[] = environment_compatible ?? [];

return miscArray.concat(envArray);

now you don't need the filter

WilsonNet · 2025-02-04T18:56:21Z

dashboard/src/utils/table.ts

+    ? [environment_misc.platform]
+    : [];
+  const envArray: string[] = environment_compatible ?? [];
+  return miscArray?.concat(envArray);


you don't need the optional chaining here

dashboard/src/components/Table/TooltipHardware.tsx

Show platform first and enviroment_compatible in the hover if it exists. Show only environment_compatible if platform is undefined Part of #864

WilsonNet · 2025-02-04T19:27:43Z

hardware details tests are not showcasing hardware

- Added platforms in the hardware column for the tests table in issue details - Added platforms in the hardware column for the tests table in build details Closes #864

WilsonNet

Works nice, I don't think adding to hardware details is part of this ticket, so I'm approving now

Francisco2002

Nice job!!

murilx self-assigned this Feb 3, 2025

murilx marked this pull request as ready for review February 4, 2025 11:52

murilx force-pushed the feat/platform-priority branch from 999211e to 88c818a Compare February 4, 2025 13:28

WilsonNet reviewed Feb 4, 2025

View reviewed changes

murilx force-pushed the feat/platform-priority branch 3 times, most recently from fcb764d to 7f0f97b Compare February 4, 2025 18:49

WilsonNet reviewed Feb 4, 2025

View reviewed changes

Francisco2002 reviewed Feb 4, 2025

View reviewed changes

dashboard/src/components/Table/TooltipHardware.tsx Outdated Show resolved Hide resolved

dashboard/src/components/Table/TooltipHardware.tsx Show resolved Hide resolved

dashboard/src/components/Table/TooltipHardware.tsx Outdated Show resolved Hide resolved

murilx force-pushed the feat/platform-priority branch from 7f0f97b to 3e6ce1c Compare February 4, 2025 19:20

feat: change hardware priority in tests table

ae02c23

Show platform first and enviroment_compatible in the hover if it exists. Show only environment_compatible if platform is undefined Part of #864

murilx force-pushed the feat/platform-priority branch from 3e6ce1c to 553b2a0 Compare February 4, 2025 19:27

feat(issue/builds): add platforms to hardware col

f17553d

- Added platforms in the hardware column for the tests table in issue details - Added platforms in the hardware column for the tests table in build details Closes #864

murilx force-pushed the feat/platform-priority branch from 553b2a0 to f17553d Compare February 4, 2025 19:29

WilsonNet approved these changes Feb 4, 2025

View reviewed changes

Francisco2002 approved these changes Feb 5, 2025

View reviewed changes

murilx merged commit 311d7ce into main Feb 5, 2025
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: change hardware priority in tests table #877

feat: change hardware priority in tests table #877

murilx commented Feb 3, 2025 •

edited

Loading

WilsonNet Feb 4, 2025 •

edited

Loading

murilx Feb 4, 2025

WilsonNet Feb 4, 2025

murilx Feb 4, 2025

WilsonNet Feb 4, 2025

WilsonNet Feb 4, 2025 •

edited

Loading

WilsonNet Feb 4, 2025

WilsonNet commented Feb 4, 2025

WilsonNet left a comment

Francisco2002 left a comment

feat: change hardware priority in tests table #877

feat: change hardware priority in tests table #877

Conversation

murilx commented Feb 3, 2025 • edited Loading

How to test

WilsonNet Feb 4, 2025 • edited Loading

Choose a reason for hiding this comment

murilx Feb 4, 2025

Choose a reason for hiding this comment

WilsonNet Feb 4, 2025

Choose a reason for hiding this comment

murilx Feb 4, 2025

Choose a reason for hiding this comment

WilsonNet Feb 4, 2025

Choose a reason for hiding this comment

WilsonNet Feb 4, 2025 • edited Loading

Choose a reason for hiding this comment

WilsonNet Feb 4, 2025

Choose a reason for hiding this comment

WilsonNet commented Feb 4, 2025

WilsonNet left a comment

Choose a reason for hiding this comment

Francisco2002 left a comment

Choose a reason for hiding this comment

murilx commented Feb 3, 2025 •

edited

Loading

WilsonNet Feb 4, 2025 •

edited

Loading

WilsonNet Feb 4, 2025 •

edited

Loading