Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codec summary report: handle "No tests found" #601

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

JenySadadia
Copy link
Collaborator

Add checks for fluster tests to avoid generating emails with "No tests found".

@JenySadadia JenySadadia requested a review from spbnick November 6, 2024 08:39
spbnick
spbnick previously approved these changes Nov 6, 2024
Copy link
Collaborator

@spbnick spbnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left one readability/style suggestion, but it's optional.

@spbnick
Copy link
Collaborator

spbnick commented Nov 6, 2024

Oh, and of course, please fix CI.

Add checks for fluster tests to avoid generating
emails with "No tests found".

Signed-off-by: Jeny Sadadia <[email protected]>
Copy link
Collaborator

@spbnick spbnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@spbnick spbnick merged commit 4f5d094 into main Nov 6, 2024
6 checks passed
@spbnick spbnick deleted the fix-fluster-no-tests branch November 6, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants