confd: ensure admin users have full access to vtysh #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Future Infix defconfigs for smaller system may exclude Frr and set all routes directly in the kernel. So failing to add a user to the frrvty group should not cause an error, hence the new group_exists(). Signed-off-by: Joachim Wiberg <[email protected]>
wkz
approved these changes
Feb 16, 2025
| @@ -45,6 +45,12 @@ static char *os = NULL; | |||
| static char *nm = NULL; | |||
| static char *id = NULL; | |||
|
|
|||
| static const char *admin_groups[] = { | |||
| "wheel", | |||
| "frrvty", | |||
There was a problem hiding this comment.
Suggested change
| "frrvty", | |
| #ifdef HAVE_FRR | |
| "frrvty", | |
| #endif |
As this list grows, having this type of structure might make it easier to keep track of which deps pull in which groups. It would also avoid the need for group_exists(). Just a thought.
Now that I think about it: Is there a podman group that we should add for builds with container support?
There was a problem hiding this comment.
Good point. I'll add that to my commit 😀👍
Not that I've seen, but I'll have a look again at podman. I'm still at it with the other related issues anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Future Infix defconfigs for smaller system may exclude Frr and set all routes directly in the kernel. So failing to add a user to the
frrvtygroup should not cause an error, hence the newgroup_exists()function.Note, the new
*_groups()functions could also be used forguestandoperatorlevel users. We've talked opening up guest access to sysrepo, relying fully on NACM, in which case we could create a new groupsysrepofor/dev/shm/*files.Checklist
Tick relevant boxes, this PR is-a or has-a: