When kestrelconnection DetachAsync does not call reader.Complete()

kerryjiang · Dec 9, 2024 · 7ec3ad6 · 7ec3ad6
1 parent 96eaf4a
commit 7ec3ad6
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/SuperSocket.Connection/PipeConnectionBase.cs b/src/SuperSocket.Connection/PipeConnectionBase.cs
@@ -305,7 +305,7 @@ protected async Task ReadPipeAsync<TPackageInfo>(PipeReader reader, IObjectPipe<
                 }
             }
 
-            reader.Complete();
+            OnReaderComplete(reader, _isDetaching);
             WriteEOFPackage();
         }
 
@@ -413,5 +413,10 @@ protected void OnError(string message, Exception e = null)
             else
                 Logger?.LogError(message);
         }
+
+        protected virtual void OnReaderComplete(PipeReader reader, bool isDetaching)
+        {
+            reader.Complete();
+        }
     }
 }
diff --git a/src/SuperSocket.Kestrel/KestrelPipeConnection.cs b/src/SuperSocket.Kestrel/KestrelPipeConnection.cs
@@ -103,4 +103,12 @@ protected override Task StartInputPipeTask<TPackageInfo>(IObjectPipe<TPackageInf
 
         return base.StartInputPipeTask(packagePipe, cancellationToken);
     }
+
+    protected override void OnReaderComplete(PipeReader reader, bool isDetaching)
+    {
+        if (isDetaching)
+            return;
+
+        reader.Complete();
+    }
 }