Deprecate cache.app configuration as tag aware

UPGRADE-7.2.md

@@ -12,7 +12,7 @@ Cache
 -----
 
  * `igbinary_serialize()` is not used by default when the igbinary extension is installed
- * Deprecate making `cache.app` pool taggable, use the `cache.app.taggable` pool instead
+ * Deprecate making `cache.app` tag aware, use the `cache.app.taggable` service instead
 
 Console
 -------

src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

@@ -2389,18 +2389,23 @@ private function registerCacheConfiguration(array $config, ContainerBuilder $con
             }
         }
         foreach (['app', 'system'] as $name) {
+            if ('cache.adapter.redis_tag_aware' === $config[$name]) {
+                trigger_deprecation('symfony/framework-bundle', '7.2', sprintf(
+                    'Using the "cache.adapter.redis_tag_aware" adapter for "cache.%s" is deprecated. You can use the "cache.app.taggable" service instead (aliased to the TagAwareCacheInterface for autowiring).',
+                    $name
+                ));
+                // throw new LogicException(sprintf(
+                //                    'Using the "cache.adapter.redis_tag_aware" adapter for "cache.%s" is deprecated. You can use the "cache.app.taggable" service instead (aliased to the TagAwareCacheInterface for autowiring).',
+                //                    $name
+                //                ));
+            }
             $config['pools']['cache.'.$name] = [
                 'adapters' => [$config[$name]],
                 'public' => true,
                 'tags' => false,
             ];
         }
         foreach ($config['pools'] as $name => $pool) {
-            if ('cache.app' === $name && $pool['tags']) {
-                trigger_deprecation('symfony/framework-bundle', '7.2', 'Using the "tags" option with the "cache.app" pool is deprecated. You can use the "cache.app.taggable" pool instead (aliased to the TagAwareCacheInterface for autowiring).');
-                // throw new LogicException('The "tags" option cannot be used with the "cache.app" pool. You can use the "cache.app.taggable" pool instead (aliased to the TagAwareCacheInterface for autowiring).');
-            }
-
             $pool['adapters'] = $pool['adapters'] ?: ['cache.app'];
 
             $isRedisTagAware = ['cache.adapter.redis_tag_aware'] === $pool['adapters'];

src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/php/cache_cacheapp_tagaware.php

@@ -6,10 +6,6 @@
     'handle_all_throwables' => true,
     'php_errors' => ['log' => true],
     'cache' => [
-        'pools' => [
-            'cache.app' => [
-                'tags' => true,
-            ],
-        ],
+        'app' => 'cache.adapter.redis_tag_aware',
     ],
 ]);

src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/cache_cacheapp_tagaware.xml

@@ -8,8 +8,6 @@
     <framework:config http-method-override="false" handle-all-throwables="true">
         <framework:annotations enabled="false" />
         <framework:php-errors log="true" />
-        <framework:cache>
-            <framework:pool name="cache.app" tags="true" />
-        </framework:cache>
+        <framework:cache app="cache.adapter.redis_tag_aware"/>
     </framework:config>
 </container>

src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/yml/cache_cacheapp_tagaware.yml

@@ -5,6 +5,4 @@ framework:
     php_errors:
         log: true
     cache:
-        pools:
-            cache.app:
-                tags: true
+        app: cache.adapter.redis_tag_aware

src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTestCase.php

@@ -1861,7 +1861,7 @@ public function testCacheTaggableTagAppliedToPools()
      */
     public function testTaggableCacheAppIsDeprecated()
     {
-        $this->expectUserDeprecationMessage('Since symfony/framework-bundle 7.2: Using the "tags" option with the "cache.app" pool is deprecated. You can use the "cache.app.taggable" pool instead (aliased to the TagAwareCacheInterface for autowiring).');
+        $this->expectUserDeprecationMessage('Since symfony/framework-bundle 7.2: Using the "cache.adapter.redis_tag_aware" adapter for "cache.app" is deprecated. You can use the "cache.app.taggable" service instead (aliased to the TagAwareCacheInterface for autowiring).');
 
         $this->createContainerFromFile('cache_cacheapp_tagaware');
     }