Merge pull request #6 from kevbaldwyn/2.1

feat: make all properties of all value objects instantiated with ValueObject readonly
kevbaldwyn · Jan 10, 2021 · d2fb11b · d2fb11b
2 parents 7f49556 + 87c0fa3
commit d2fb11b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/CompositeValueObject.ts b/src/CompositeValueObject.ts
@@ -6,10 +6,6 @@ export type CompositeProperties = Record<string, ValueObject<unknown>>;
 export class CompositeValueObject<
   T extends CompositeProperties
 > extends ValueObject<T> {
-  constructor(args: T) {
-    super(Object.freeze(args));
-  }
-
   public isSame = (object: ValueObject<CompositeProperties>): boolean => {
     return ObjectUtils.isObjectEqual(
       this.toNative(),

diff --git a/src/ValueObject.ts b/src/ValueObject.ts
@@ -36,6 +36,9 @@ export abstract class ValueObject<V> implements ValueObjectInterface<V> {
 
   constructor(value: V) {
     this.value = value;
+    if (typeof this.value === "object") {
+      Object.freeze(this.value);
+    }
   }
 
   abstract isSame(object: ValueObjectInterface<V>): boolean;