Extend body filtering to handle non-POST methods#1004
Open
andrescollares wants to merge 1 commit into
Open
Conversation
andrescollares
marked this pull request as ready for review
June 23, 2026 02:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should solve #328.
It's also a potential breaking change if users aren't expecting requests that are not POSTs to be filtered.
If this is a big problem, an idea that I had was to add an optional parameter to
replace_body_parametersthat contains a tuple of methods to be filtered by, that way we could keep only "POST" by default and let users extend it or set it as None (no method check) if they want to.Used a local llm to help me refactor the tests.