Fix compatibility issues under PHP 8.1, which may cause opcache compilation errors #345
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
JavascriptDate
class included in this package has an incompatible constructor with its parent class,Carbon
.This won't cause issues prior to PHP 8.1 — and is unlikely to even affect those using 8.1 anyway, as the
JavascriptDate
class doesn't actually seem to be called anywhere in the package :)However... If you try to pre-compile your application scripts with the PHP opcache, an
E_COMPILE_ERROR
is thrown, which can randomly cause your entire autoloader to break 🧨 (as I found out the hard way...). This is due to a PHP bug, which has only recently been fixed (php/php-src#8164)A new release tagged as
3.1.15
would be great. Thank you!