fixed: column "billable" is not correctly imported

kevinpapst · Nov 3, 2023 · 05faf47 · 05faf47
1 parent 02abaf9
commit 05faf47
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## Version 2.5.1 (03.11.2023)
+
+Compatibility: requires minimum Kimai 2.1.0
+
+- Fixed: Column "Billable" is not correctly imported
+
 ## Version 2.5.0
 
 Compatibility: requires minimum Kimai 2.1.0

diff --git a/Importer/AbstractTimesheetImporter.php b/Importer/AbstractTimesheetImporter.php
@@ -232,9 +232,7 @@ public function importRow(Duration $durationParser, ImportData $data, ImportRow
             $timesheet = $this->timesheetService->createNewTimesheet($user);
             $this->timesheetService->prepareNewTimesheet($timesheet);
 
-            if (\is_bool($record['Billable'])) {
-                $timesheet->setBillable($this->convertBoolean($record['Billable']));
-            }
+            $timesheet->setBillable($this->convertBoolean($record['Billable']));
             $timesheet->setActivity($activity);
             $timesheet->setProject($project);
             $timesheet->setBegin($begin);

diff --git a/composer.json b/composer.json
@@ -3,7 +3,7 @@
     "description": "Import data from CSV files via Web UI",
     "homepage": "https://www.kimai.org/store/keleo-importer-bundle.html",
     "type": "kimai-plugin",
-    "version": "2.5.0",
+    "version": "2.5.1",
     "keywords": [
         "kimai",
         "kimai-plugin"