fix clockify rounding issue

kevinpapst · May 19, 2024 · 3c2b9f3 · 3c2b9f3
1 parent da5c8e0
commit 3c2b9f3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,10 @@
+## Version 2.13.0
+
+Compatibility: requires minimum Kimai 2.11.0
+
+- Support importing seconds
+- Fixed Clockify duration import rounding issue (see [#4838](https://github.com/kimai/kimai/issues/4838))
+
 ## Version 2.12.0
 
 Compatibility: requires minimum Kimai 2.11.0

diff --git a/Importer/ClockifyTimesheetImporter.php b/Importer/ClockifyTimesheetImporter.php
@@ -119,12 +119,15 @@ public function importRow(Duration $durationParser, ImportData $data, ImportRow
                 case 'Start Time':
                 case 'End Date':
                 case 'End Time':
-                case 'Duration (h)':
                     // nothing to do
                     break;
-                case 'Duration (decimal)':
+                case 'Duration (h)':
                     $values['Duration'] = $durationParser->parseDurationString((string) $value);
                     break;
+                case 'Duration (decimal)':
+                    // see https://github.com/kimai/kimai/issues/4838 - rounding issues cause minute loss
+                    // $values['Duration'] = $durationParser->parseDurationString((string) $value);
+                    break;
                 default:
                     if (str_starts_with($key, 'Billable Rate')) {
                         $values['HourlyRate'] = $value;