Omit setting the length when in base64 transmission mode. #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was setting the file length, which was the wrong length for the encoded data.
rkoumis
commented
Mar 12, 2024
| self.length = os.path.getsize(self.path) | ||
| if self.okay_to_send(): | ||
| if self.encoding != BASE_64_ENCODING: | ||
| self.length = os.path.getsize(self.path) |
There was a problem hiding this comment.
This is the fix. Previously we were always setting the length. Now, we'll skip setting the length when base64 transmission is called for.
rkoumis
commented
Mar 12, 2024
|
|
||
| def write(self, httplog, sock): | ||
| if not self.length: | ||
| if not self.okay_to_send(): |
There was a problem hiding this comment.
Can't use self.length any longer to check if it's okay to send the file.
rkoumis
commented
Mar 12, 2024
| decoded = base64.b64decode(r.text + "==").decode() | ||
| assert "test data" in decoded | ||
| assert first_line in decoded | ||
| assert last_line in decoded |
There was a problem hiding this comment.
Make sure we receive even the very last line of the file.
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omit setting the length when in base64 transmission mode.
It was setting the file length, which was the wrong length for the encoded data.
The received data were truncated.