ECal endcap turbine version 3 #426
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen split into layers
There was a problem hiding this comment.
Hi @varnes
please get rid of all the unnecessary changes and of the commented code. Apart from that, the changes look good to me
FCCee/ALLEGRO/compact/ALLEGRO_o1_v03/HCalBarrel_TileCal_v02.xml
Outdated
Show resolved
Hide resolved
FCCee/ALLEGRO/compact/ALLEGRO_o1_v03/HCalEndcaps_ThreeParts_TileCal_v02.xml
Outdated
Show resolved
Hide resolved
| double bathThicknessFront = aLcdd.constant<float>("BathThicknessFront"); | ||
| double bathThicknessBack = aLcdd.constant<float>("BathThicknessBack"); | ||
|
|
||
| // double cryoThicknessInner = aLcdd.constant<float>("CryoEMECThicknessInner"); |
There was a problem hiding this comment.
remove commented code
| dd4hep::Tube bathOuterShape(bathRmin, bathRmax, bathDelZ); // make it 4 volumes + 5th for detector envelope | ||
| dd4hep::Tube bathAndServicesOuterShape(cryoDim.rmin2(), cryoDim.rmax1(), caloDim.dz()); // make it 4 volumes + 5th for detector envelope | ||
| // dd4hep::Tube bathAndServicesOuterShape(cryoDim.rmin2(), cryoDim.rmax1(), caloDim.dz()); // make it 4 volumes + 5th for detector envelope |
There was a problem hiding this comment.
remove commented code
| @@ -647,17 +707,17 @@ namespace det { | |||
| dd4hep::PlacedVolume envelopePositivePhysVol = endcapsAssembly.placeVolume(envelopeVol, envelopePositiveVolume_tr); | |||
| envelopePositivePhysVol.addPhysVolID("side", 1); | |||
|
|
|||
| dd4hep::DetElement caloPositiveDetElem(caloDetElem, "positive", 0); | |||
| caloPositiveDetElem.setPlacement(envelopePositivePhysVol); | |||
| // dd4hep::DetElement caloPositiveDetElem(caloDetElem, "positive", 0); | |||
There was a problem hiding this comment.
remove commented code
|
|
||
| // make another placement for the negative z endcap | ||
| dd4hep::Transform3D envelopeNegativeVolume_tr(dd4hep::RotationZYX( 0 ,0,180*dd4hep::deg), dd4hep::Translation3D(0, 0, -dim.z_offset())); | ||
| dd4hep::PlacedVolume envelopeNegativePhysVol = | ||
| endcapsAssembly.placeVolume(envelopeVol, envelopeNegativeVolume_tr); | ||
| envelopeNegativePhysVol.addPhysVolID("side", -1); | ||
|
|
||
| dd4hep::DetElement caloNegativeDetElem(caloDetElem, "negative", 0); | ||
| caloNegativeDetElem.setPlacement(envelopeNegativePhysVol); | ||
| // dd4hep::DetElement caloNegativeDetElem(caloDetElem, "negative", 0); |
There was a problem hiding this comment.
remove commented code
added 9 commits
January 30, 2025 18:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
This PR is to support v3 of the ECal endcap turbine geometry. In this version there is flexibility to set parameters separately for the three wheels, to calibrate the response in both dimensions along the surface of a blade, and the segment the readout in both directions as well. The readout unit cells are allowed to be smaller than the calibration cells.
(Note that the above changes were implemented in two steps, with the flexibility to set parameters separately introduced in "v2" of the geometry, and the remaining changes in v3. v2 was never included in a pull request.)
ENDRELEASENOTES