Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the MDI Version of the ILD FCCee Models to MDI_o1_v01 #428

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Victor-Schwan
Copy link
Contributor

On @BrieucF 's recommendation, the default MDI version of the ILD FCCee models is changed to MDI_o1_v01.

BEGINRELEASENOTES

  • change the MDI version of the ILD FCCee models to MDI_o1_v01
  • minor: remove some trailing whitespaces in the ILD FCCee config files

ENDRELEASENOTES

@Victor-Schwan
Copy link
Contributor Author

fyi @danieljeans

@Victor-Schwan
Copy link
Contributor Author

checks fail because the stl files for MDI_o1_v01 are not available in the test environment

@atolosadelgado
Copy link
Collaborator

Hi @Victor-Schwan,

It seems that the release currently does not provide the CAD files necessary to build the fancy beampipe, which is causing the tests for ILD to fail. To address this, I would suggest one of the following options:

  • Consider disabling the CAD file option for the ILD model used in the tests. You could still include additional ILD models that aren't tested, but rely on the MDI model.
  • Alternatively, we could remove the ILD test from the ctest, though I understand this may not be the most ideal solution.

Let me know your thoughts, and I'd be happy to discuss further.

@BrieucF
Copy link
Contributor

BrieucF commented Jan 31, 2025

Or we enable the cmake option INSTALL_BEAMPIPE_STL_FILES by default?

@tmadlener
Copy link
Contributor

key4hep/key4hep-actions#9 would make it possible to easily pass that additional option for the CI.

@Victor-Schwan
Copy link
Contributor Author

I am in favor of adapting the tests such that the cmake option INSTALL_BEAMPIPE_STL_FILES is enabled by default as soon as key4hep/key4hep-actions#9 has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants