This repository was archived by the owner on Dec 14, 2023. It is now read-only.
Conversation
tlyu
force-pushed
the
hybrid-bootkb
branch
2 times, most recently
from
23fbe5c to
58138fe
Compare
Make the Boot Keyboard the only keyboard, and make it have a hybrid report format in Report Protoocol, while still ending Boot Reports in Boot Protocol. The hybrid reports have the Boot Report as a prefix, which might help hosts that don't request Boot Protocol but still expect to see it. Include a way to switch between the hybrid report, and sending only Boot Protocol regardless of whether the host has requested it. Defaults to sending hybrid protocol, but this can be changed at compile time. Signed-off-by: Taylor Yu <code@argon.blue>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the Boot Keyboard the only keyboard, and make it have a hybrid
report format in Report Protoocol, while still ending Boot Reports in
Boot Protocol. The hybrid reports have the Boot Report as a prefix,
which might help hosts that don't request Boot Protocol but still
expect to see it.
Include a way to switch between the hybrid report, and sending only
Boot Protocol regardless of whether the host has requested it. Defaults
to sending hybrid protocol, but this can be changed at compile time.
Fixes keyboardio/Kaleidoscope#1305, when combined with keyboardio/Kaleidoscope#1361. They are probably not safe to apply independently.
As a side effect, fixes #98. Also fixes a minor bug with the boot keyboard's report descriptor, and compacts them a bit by more strategic use of global state.