improving logging

Signed-off-by: Pedro Igor <[email protected]>
keycloak · Jun 20, 2024 · db917d6 · db917d6
1 parent 7fce05d
commit db917d6
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 10 deletions.
diff --git a/dataset/src/main/java/org/keycloak/benchmark/dataset/Task.java b/dataset/src/main/java/org/keycloak/benchmark/dataset/Task.java
@@ -18,6 +18,7 @@
 
 package org.keycloak.benchmark.dataset;
 
+import java.time.Duration;
 import java.util.Date;
 import java.util.HashMap;
 import java.util.Map;
@@ -90,7 +91,14 @@ public String getTaskMessage() {
 
     @Override
     public String toString() {
-        return String.format("%s, started: %s", taskMessage, new Date(startTimeMs));
+        boolean running = endTimeMs == null;
+        Long endTimeMs = this.endTimeMs;
+
+        if (running) {
+            endTimeMs = Time.currentTimeMillis();
+        }
+
+        return String.format("%s, running: %s, time: %ss, started: %s, ended: %s", taskMessage, running, Duration.ofMillis(endTimeMs - startTimeMs).toSeconds(), new Date(startTimeMs), new Date(endTimeMs));
     }
 
     public Boolean isSuccess() {

diff --git a/.../main/java/org/keycloak/benchmark/dataset/organization/OrganizationMemberProvisioner.java b/.../main/java/org/keycloak/benchmark/dataset/organization/OrganizationMemberProvisioner.java
@@ -110,9 +110,7 @@ protected void addUnmanagedMembers(KeycloakSession session, String orgId, CountD
         OrganizationModel organization = provider.getById(orgId);
         session.users().searchForUserStream(realm, Map.of(UserModel.INCLUDE_SERVICE_ACCOUNT, Boolean.FALSE.toString()))
                 .filter((u) -> provider.getByMember(u) == null)
-                .takeWhile(userModel -> {
-                    return latch.getCount() > 0;
-                })
+                .takeWhile(userModel -> latch.getCount() > 0)
                 .forEach(userModel -> {
                     provider.addMember(organization, userModel);
                     latch.countDown();

diff --git a/...et/src/main/java/org/keycloak/benchmark/dataset/organization/OrganizationProvisioner.java b/...et/src/main/java/org/keycloak/benchmark/dataset/organization/OrganizationProvisioner.java
@@ -121,11 +121,9 @@ private Runnable createOrganizations() {
                                     createOrganization(config.getOrgPrefix() + j, s, config);
                                 }
 
-                                logger.infof("Created organizations in realm %s from %d to %d", getRealmName(), orgStartIndex, endIndex);
+                                int createdCount = endIndex - orgStartIndex;
 
-                                if (((endIndex - startIndex) / config.getEntriesPerTransaction()) % 20 == 0) {
-                                    logger.infof("Created %d organizations in realm %s", count, getRealmName());
-                                }
+                                logger.infof("Created %d organizations in realm %s from %d to %d", createdCount, getRealmName(), orgStartIndex, endIndex);
                             });
                         }
                     } else {
@@ -135,9 +133,9 @@ private Runnable createOrganizations() {
 
                 executor.waitForAllToFinish();
                 success();
-                logger.infof("Created %d organizations in realm %s", count, getRealmName());
             } catch (Exception e) {
                 cleanup(executor);
+                logger.error("Failed to provision organizations", e);
             }
         };
     }
@@ -151,7 +149,7 @@ private void createOrganization(String name, KeycloakSession session, DatasetCon
             return;
         }
 
-        OrganizationModel organization = orgProvider.create(name);
+        OrganizationModel organization = orgProvider.create(name, name);
         int domainsCount = config.getDomainsCount();
         String domains = Optional.ofNullable(config.getDomains()).filter(StringUtil::isNotBlank).orElse(name);