Update machinepool manipulation based on the latest changes in ROSA (#…

…559)
keycloak · Sep 26, 2023 · fa745b9 · fa745b9
1 parent 7794045
commit fa745b9
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 10 deletions.
diff --git a/.github/workflows/keycloak-scalability-benchmark.yml b/.github/workflows/keycloak-scalability-benchmark.yml
@@ -93,7 +93,7 @@ jobs:
 
       - name: Allow cluster to scale
         if: ${{ !inputs.skipCreateDeployment }}
-        run: rosa edit machinepool -c ${{ inputs.clusterName }} --min-replicas 3 --max-replicas 10 scaling
+        run: rosa edit machinepool -c ${{ inputs.clusterName }} --min-replicas 3 scaling
 
       - name: Create Keycloak deployment
         if: ${{ !inputs.skipCreateDeployment }}
@@ -183,7 +183,7 @@ jobs:
 
       - name: Scale down the cluster
         if: ${{ (success() || failure()) && !inputs.skipDeleteProject }}
-        run: rosa edit machinepool -c ${{ inputs.clusterName }} --min-replicas 0 --max-replicas 0 scaling
+        run: rosa edit machinepool -c ${{ inputs.clusterName }} --min-replicas 0 scaling
 
   archive:
     name: Commit results to Git repository

diff --git a/.github/workflows/rosa-scaling-benchmark.yml b/.github/workflows/rosa-scaling-benchmark.yml
@@ -105,7 +105,7 @@ jobs:
 
       - name: Allow cluster to scale
         if: ${{ !inputs.skipCreateDeployment }}
-        run: rosa edit machinepool -c ${{ inputs.clusterName }} --min-replicas 3 --max-replicas 10 scaling
+        run: rosa edit machinepool -c ${{ inputs.clusterName }} --min-replicas 3 scaling
 
       - name: Create Keycloak deployment
         if: ${{ !inputs.skipCreateDeployment }}
@@ -309,7 +309,7 @@ jobs:
 
       - name: Scale down the cluster
         if: ${{ (success() || failure()) && !inputs.skipDeleteProject }}
-        run: rosa edit machinepool -c ${{ inputs.clusterName }} --min-replicas 0 --max-replicas 0 scaling
+        run: rosa edit machinepool -c ${{ inputs.clusterName }} --min-replicas 0 scaling
 
   archive:
     name: Commit results to Git repository

diff --git a/doc/benchmark/modules/ROOT/pages/report/rosa-benchmark-key-results.adoc b/doc/benchmark/modules/ROOT/pages/report/rosa-benchmark-key-results.adoc
@@ -121,7 +121,7 @@ Each test ran for 10 minutes.
 +
 [source,bash,subs="+quotes"]
 ----
-rosa edit machinepool -c  **<clustername>** --min-replicas 3 --max-replicas 10 scaling
+rosa edit machinepool -c  **<clustername>** --min-replicas 3 scaling
 ----
 . Deploy Keycloak and Monitoring
 +

diff --git a/doc/kubernetes/modules/ROOT/pages/prerequisite/prerequisite-rosa.adoc b/doc/kubernetes/modules/ROOT/pages/prerequisite/prerequisite-rosa.adoc
@@ -86,20 +86,21 @@ The above installation script creates an admin user automatically but in case th
 == Scaling the cluster's nodes on demand
 
 The standard setup of nodes might be too small for running a load test, at the same time using a different instance type and rebuilding the cluster takes a lot of time (about 45 minutes).
-To scale the cluster on demand, the standard setup has a machine pool named `scaling` with instances of type `m5.4xlarge` spot instances which is scaled to zero by default.
+To scale the cluster on demand, the standard setup has a machine pool named `scaling` with instances of type `m5.4xlarge` which is auto-scaled based on the current demand from 0 to 10 instances.
+However, auto-scaling of worker nodes is quite time-consuming as nodes are scaled one by one.
 
-To scale the machine pool at runtime, issue a command like the following, and the additional nodes will be available within about 5 minutes:
+To scale the machine pool faster, issue a command like the following, and the additional nodes will be spawned at the same time:
 
 [source,bash,subs=+quotes]
 ----
-rosa edit machinepool -c _**clustername**_ --min-replicas 3 --max-replicas 10 scaling
+rosa edit machinepool -c _**clustername**_ --min-replicas 3 scaling
 ----
 
-To scale down the cluster, use a command like the following:
+To allow scaling the machine pool back to 0, use a command like the following:
 
 [source,bash,subs=+quotes]
 ----
-rosa edit machinepool -c _**clustername**_ --min-replicas 0 --max-replicas 0 scaling
+rosa edit machinepool -c _**clustername**_ --min-replicas 0 scaling
 ----
 
 To use different instance types, use `rosa create machinepool` to create additional machine pools