Skip to content

Commit

Permalink
Updating to the latest version, part 2
Browse files Browse the repository at this point in the history
Signed-off-by: Alexander Schwartz <[email protected]>
  • Loading branch information
ahus1 committed Jul 1, 2024
1 parent 0ced19d commit fe19fdf
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
public class KeycloakServer {

private static final String KEYCLOAK_VERSION = System.getProperty("keycloak.version", "999.0.0-SNAPSHOT");

This comment has been minimized.

Copy link
@kami619

kami619 Jul 2, 2024

Contributor

@ahus1 Would this be overridden in the case of an artifact with (keycloak.version,25.0.1) ?

This comment has been minimized.

Copy link
@ahus1

ahus1 Jul 3, 2024

Author Contributor

Yes, good point!

This comment has been minimized.

Copy link
@ahus1

ahus1 Jul 3, 2024

Author Contributor

The proper way to do this would be passing in the values via

<forkNode implementation="org.apache.maven.plugin.surefire.extensions.SurefireForkNodeFactory"/>
<systemPropertyVariables>
<java.util.logging.manager>org.jboss.logmanager.LogManager</java.util.logging.manager>
</systemPropertyVariables>
- and then we wouldn't need those constants any more.

private static final String PROJECT_VERSION = System.getProperty("project.version", "0.13-SNAPSHOT");
private static final String PROJECT_VERSION = System.getProperty("project.version", "0.14-SNAPSHOT");

public static void main(String[] rawArgs) {
List<String> args = new ArrayList<>(Arrays.asList(rawArgs));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ See xref:run/running-benchmark-ansible.adoc[] for details.
cluster_size: 5
instance_type: t4g.small
instance_volume_size: 30
kcb_zip: ../benchmark/target/keycloak-benchmark-0.13-SNAPSHOT.zip
kcb_zip: ../benchmark/target/keycloak-benchmark-0.14-SNAPSHOT.zip
kcb_heap_size: 1G
----

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ Use the file `link:{github-files}/ansible/env_example.yml[env_example.yaml]` as
.Example contents to configure the benchmark execution via `env.yml`
[source,yaml]
----
kcb_zip: ../benchmark/target/keycloak-benchmark-0.13-SNAPSHOT.zip
kcb_zip: ../benchmark/target/keycloak-benchmark-0.14-SNAPSHOT.zip
kcb_heap_size: 1G
----

Expand Down

0 comments on commit fe19fdf

Please sign in to comment.