Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dataset provider to use JakartaEE dependencies used in KC22 #328

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Upgrade dataset provider to use JakartaEE dependencies used in KC22 #328

merged 1 commit into from
Apr 28, 2023

Conversation

ahus1
Copy link
Contributor

@ahus1 ahus1 commented Apr 28, 2023

Changed to latest JakarataEE dependencies used in Keycloak upstream.

Removed special dependency handling around RESTEasy and the tests show this is no longer necessary.

Closes #327

@ahus1 ahus1 marked this pull request as ready for review April 28, 2023 08:46
@ahus1 ahus1 requested a review from mhajas April 28, 2023 08:46
@ahus1
Copy link
Contributor Author

ahus1 commented Apr 28, 2023

Hi @mhajas - this is now ready for review. There is an integration test DeploymentIT which ensure that the dataset provider works as expected with the legacy and new store. This one is green, and I trust on that test result so consider this ready to be merged.

@ahus1 ahus1 mentioned this pull request Apr 28, 2023
Closed
mhajas
mhajas approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@mhajas mhajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update @ahus1

@mhajas mhajas merged commit 0989563 into keycloak:main Apr 28, 2023
@ahus1 ahus1 deleted the is-327-compatibilty-jakarta-ee branch May 23, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhajas mhajas mhajas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compilation failure when building main
2 participants
@ahus1 @mhajas