Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub workflows to create and delete a shared ROSA cluster #345

Merged
merged 1 commit into from
May 26, 2023

Conversation

stianst
Copy link
Contributor

@stianst stianst commented May 26, 2023

@stianst stianst marked this pull request as draft May 26, 2023 07:15
@stianst stianst marked this pull request as ready for review May 26, 2023 08:45
working-directory: provision/aws
env:
VERSION: ${{ env.OPENSHIFT_VERSION }}
CLUSTER_NAME: shared
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Then we can add the cluster name as the parameter for the benchmark run.

@kami619
Copy link
Contributor

kami619 commented May 26, 2023

@stianst

In the referenced run : https://github.com/stianst/keycloak-benchmark/actions/runs/5088576833/jobs/9145155404

Login failed (401 Unauthorized)
Verify you have provided the correct credentials.
2023-05-26T08:39:44+00:00
WARNING: Using insecure TLS client config. Setting this option is not supported!

I see that it failed to authenticate a bunch of times before it succeeded., which is unlike the behavior we saw on local runs., is this expected ?

@kami619
Copy link
Contributor

kami619 commented May 26, 2023

also we are generating some debug logs for each custer create and delete using rosa scripts, do we want to retrieve them somehow for debugging the errors on aws or otherwise ? if you think, that should be done in a future PR, thats OK with me too. @stianst

@stianst
Copy link
Contributor Author

stianst commented May 26, 2023

@stianst

In the referenced run : https://github.com/stianst/keycloak-benchmark/actions/runs/5088576833/jobs/9145155404

Login failed (401 Unauthorized)
Verify you have provided the correct credentials.
2023-05-26T08:39:44+00:00
WARNING: Using insecure TLS client config. Setting this option is not supported!

I see that it failed to authenticate a bunch of times before it succeeded., which is unlike the behavior we saw on local runs., is this expected ?

I changed it to not wait for 1m, but instead just keep trying every 10 seconds, so that'll be the reason for a few more failures there. I think it is better to have it fail a few times, then waiting for too long?

@stianst
Copy link
Contributor Author

stianst commented May 26, 2023

I'd say let's add it later. Probably just grab the logs and store as artifacts if it fails to deploy. Don't think we need any logs if it is successful? Related to this is we could probably also make sure everything is cleaned-up if something fails.

Copy link
Contributor

@kami619 kami619 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed on log management to be taken care later, fine for it fail fast, than have to wait. This PR looks good to be merged, if there are no other comments

@stianst stianst merged commit 3aa834c into keycloak:main May 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants