Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run benchmark workflow #347

Merged
merged 6 commits into from
May 30, 2023
Merged

Run benchmark workflow #347

merged 6 commits into from
May 30, 2023

Conversation

stianst
Copy link
Contributor

@stianst stianst commented May 26, 2023

No description provided.

stianst
stianst commented May 26, 2023
View reviewed changes
provision/openshift/isup.sh Outdated Show resolved Hide resolved
@kami619 @stianst
Apply suggestions from code review
403028e 
Co-authored-by: Stian Thorgersen <[email protected]>
mhajas
mhajas reviewed May 29, 2023
View reviewed changes
Copy link
Contributor

@mhajas mhajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stianst, the Pr looks good to me after the last suggestion from @kami619 is addressed with benchmark version in upload-artifact action.

@stianst
Copy link
Contributor Author

stianst commented May 30, 2023

Did a run of the last iteration here:
https://github.com/stianst/keycloak-benchmark/actions/runs/5118671819

Will of course squash and merge this one since it now has a few commits ;)

mhajas
mhajas approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@mhajas mhajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @stianst!

@mhajas mhajas merged commit 9ee93ed into keycloak:main May 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kami619 kami619 kami619 left review comments

@mhajas mhajas mhajas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stianst @kami619 @mhajas