-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated scheduling of creation of shared ROSA cluster and another end of business reaper #352
Automated scheduling of creation of shared ROSA cluster and another end of business reaper #352
Conversation
@kami619 running out a bit of time before leaving for PTO, and not sure I explained correctly what I proposed, so will try to explain here:
Now to schedule the above you can either do:
Personally I like separating the schedule from the workflow, so leaning towards 2. As you can see in https://github.com/keycloak/keycloak-quickstarts/blob/latest/.github/workflows/schedule.yml it's fairly simple to create a schedule workflow that is only used to execute another workflow. |
d51ea2e
to
d7cdd7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kami619 for the changes. I added two more comments.
d7cdd7b
to
f952f02
Compare
@mhajas last round 🥊 :) review 🤞🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes @kami619, LGTM!
I updated the README.md
file a little bit because the items were wrongly numbered.
…nd of business reaper (keycloak#352) Fixes keycloak#351
Adding two new workflow files:
Setting static values for cluster creation, as below:
and a Rosa cluster reaper scripts, which takes input of a list of "ready" state clusters
My first attempt at GH workflow's so if something's amiss, please correct it :)
Open question, there could be cluster's which could be in other
states
other thanready
, do we want any alert on it ? Another question is, do we want any email notification after the job is complete, alternative would be to personally tune the GH Workflow notifications to report on this workflow, reducing the email clutter.