Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add refresh token phase to AuthorizationCode scenario #434

Merged
merged 17 commits into from
Aug 1, 2023

Conversation

ddurham2
Copy link
Contributor

@ddurham2 ddurham2 commented Jul 19, 2023

refresh token load test scenario

resolves #416

@kami619
Copy link
Contributor

kami619 commented Jul 28, 2023

@ddurham2 I am currently testing this locally, do you think anything else is left on this PR before we can take this forward and move it from Draft status to Ready for review ? Also made some minor changes to make the code little bit more explicit.

@ddurham2
Copy link
Contributor Author

Yes, I'm still tweaking it locally. I'm both doing tests and adjusting KC and adjusting the tests as I go. I did get it up to 100k on a local minikube deployment. I still need to figure out how to specify some of the testing parameters which are new for this test, I think.
I'll try and commit some things shortly.

@@ -29,7 +29,7 @@ DIRNAME=$(dirname "$RESOLVED_NAME")

# Default values
JAVA_OPTS="-server"
JAVA_OPTS="${JAVA_OPTS} -Xmx1G -XX:+HeapDumpOnOutOfMemoryError"
JAVA_OPTS="${JAVA_OPTS} -Xmx4G -XX:+HeapDumpOnOutOfMemoryError"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw the gatling java process up in the 3.5GB range when ramping up to 100k users

…s during the scenario share connections

using --refresh-token-period instead of --user-think-time for delay between refreshes
… default it does the same things but without a refresh
@ddurham2 ddurham2 changed the title refresh token load test scenario add refresh token phase to AuthorizationCode scenario Aug 1, 2023
@ddurham2 ddurham2 marked this pull request as ready for review August 1, 2023 05:20
@kami619
Copy link
Contributor

kami619 commented Aug 1, 2023

@ahus1 - I did the test with both minikube and openshift and also with the ec2 load runners and local benchmark, things looked good to me. do you want to give this a last look, before I merge it ?

@ahus1
Copy link
Contributor

ahus1 commented Aug 1, 2023

Thank you @ddurham2 for contributing this change and @kami619 for reviewing it thoroughly!

I added one tiny bit in f0d86cb I remember from a previous life, that one using shared connections, it used to make sense to increase he maxConnectionsPerHost.

I'm now merging this.

@ahus1 ahus1 merged commit d5fcbdc into keycloak:main Aug 1, 2023
2 checks passed
@ddurham2
Copy link
Contributor Author

ddurham2 commented Aug 1, 2023

Thanks guys. Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a token refresh load testing scenario
3 participants