Refine Ansible playbook with max users per node and async execution #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhajas
reviewed
Jul 28, 2023
kami619
reviewed
Jul 28, 2023
kami619
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
tested both positive and negative flows for users-per-sec condition, it works as expected. Couldn't test the ssh connection in a reliable way, but hope the provided async poll fix works seamlessly. LGTM overall, thanks for improving the playbooks further @ahus1
ahus1
force-pushed
the
refine-ansible-scripts-async-max-users
branch
from
7941e15
to
f3ee16c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help when the SSH connection is unstable.
When running it this way, there are a lot of additional log messages for the polling - I hope you don't mind.
It also catches the problem automatically which was previous only documented, but not enforced.