Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation of Rosa Scaling Benchmark (#444): Part 1 #462

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

andyuk1986
Copy link
Contributor

Refers to #444

@andyuk1986
Copy link
Contributor Author

I am archiving the results directory which contains already aggregated report. Also as a summary I am archiving the stats.json files (saw that in other workflow). Please let me know, if it is necessary and if I need to commit results or summary or both to git repo (also have seen in other workflow).

@ahus1
Copy link
Contributor

ahus1 commented Aug 8, 2023

@andyuk1986 - I did a first review, and had a successful build when I chose just some very small values. See https://github.com/ahus1/keycloak-benchmark/actions/runs/5795138289/job/15706106755

I was wondering if I could remove the deployMonitoring, as the metrics would be recorded by Prometheus anyway. Let me know your thoughts.

I'm now doing another full run to see the result.

Some notes about the changes I did:

  • Actions don't have types, and their defaults are always strings
  • Create and delete work without start and stop
  • I made the measurement period a parameter, to have faster smoke tests after script changes
  • users per realm now matches the number of created entities

@andyuk1986
Copy link
Contributor Author

andyuk1986 commented Aug 8, 2023

@ahus1 - thanks a lot for the review. Very nice solution for ansible environment file, thanks for adding it. And yes, the deployMonitoring flag can be removed as prometheus records metrics anyway. I will remove that and I can squash commits to one.

@andyuk1986
Copy link
Contributor Author

I have removed the deployMonitoring implementation part. May I squash the commits?

@ahus1 ahus1 merged commit 4065532 into keycloak:main Aug 9, 2023
2 checks passed
@ahus1
Copy link
Contributor

ahus1 commented Aug 9, 2023

@andyuk1986 - yes, merging would have been ok, but I also have the button on the GitHub UI to squash them during the merge - and this is what I did.

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants