Use static password in the Hot Rod endpoint #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pruivo
commented
Aug 7, 2023
| @@ -198,19 +195,16 @@ tasks: | |||
| if [ "{{.KC_ISPN_NAMESPACE}}" != "" ]; then | |||
| echo "true" > .task/remote-store-enabled | |||
| echo "infinispan.{{.KC_ISPN_NAMESPACE}}.svc" > .task/remote-store-host | |||
| oc -n {{.KC_ISPN_NAMESPACE}} get secrets infinispan-generated-secret -o 'jsonpath={.data.identities\.yaml}' | base64 -d | yq .credentials[0].username > .task/remote-store-username | |||
| oc -n {{.KC_ISPN_NAMESPACE}} get secrets infinispan-generated-secret -o 'jsonpath={.data.identities\.yaml}' | base64 -d | yq .credentials[0].password > .task/remote-store-password | |||
| oc -n {{.KC_ISPN_NAMESPACE}} get secrets connect-secret -o 'jsonpath={.data.identities\.yaml}' | base64 -d | yq .credentials[0].password > .task/remote-store-password | |||
There was a problem hiding this comment.
Should I keep fetching the password from the secret or convert this to a variable?
There was a problem hiding this comment.
is this a secret generated by the operator ? @pruivo how much of an effort would it be to fetch it from the AWS IAM and keep it common with all other passwords ? --secret-id "$KEYCLOAK_MASTER_PASSWORD_SECRET_NAME"
pruivo
commented
Aug 7, 2023
| kind: Secret | ||
| type: Opaque | ||
| metadata: | ||
| name: connect-secret |
There was a problem hiding this comment.
@kami619 the secret is generated here with the password from AWS.
There was a problem hiding this comment.
in this case we don't need it to be a variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 changes included in the PR:
KC_ISPN_PORTsince it is not possible to change it.