Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove password-hash-iterations from dataset module config #751

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

kami619
Copy link
Contributor

@kami619 kami619 commented Mar 27, 2024

Fixes #744

@kami619 kami619 changed the title removing references for and defaulting to what Keycloak provides to remove ambiguity remove password-hash-iterations from dataset module config Mar 27, 2024
@kami619
Copy link
Contributor Author

kami619 commented Mar 28, 2024

Able to generate 1 million users in 2.37 hrs using the dataset module with the removed references from the dataset provider about hashing iterations.

{"timestamp":"2024-03-28T15:25:00.327252386Z","sequence":63032,"loggerClassName":"org.jboss.logging.Logger","loggerName":"org.keycloak.benchmark.dataset.DatasetResourceProvider","level":"INFO","message":"Created all 1000000 users in realm realm-2, Time since start of the task 'Creation of 1000000 users in the realm realm-2': 8544827 ms","threadName":"Thread-44","threadId":145,"mdc":{},"ndc":"","hostName":"keycloak-2","processName":"QuarkusEntryPoint","processId":1}

Able to confirm the hashing is matching to whats expected.
Screenshot 2024-03-28 at 12 55 36

Resource utilization during the time with the -XX:MinRAMPercentage=30.000000 set:

Output of $jcmd 1 VM.flags

-XX:AdaptiveSizePolicyWeight=90 -XX:CICompilerCount=12 -XX:CompressedClassSpaceSize=218103808 -XX:+ExitOnOutOfMemoryError -XX:FlightRecorderOptions=stackdepth=512 -XX:GCTimeRatio=4 -XX:InitialHeapSize=2000683008 -XX:InitialRAMPercentage=50.000000 -XX:+ManagementServer -XX:MaxHeapFreeRatio=20 -XX:MaxHeapSize=2801795072 -XX:MaxMetaspaceSize=268435456 -XX:MaxNewSize=933756928 -XX:MaxRAM=3999997952 -XX:MaxRAMPercentage=70.000000 -XX:MetaspaceSize=100663296 -XX:MinHeapDeltaBytes=524288 -XX:MinHeapFreeRatio=10 -XX:MinHeapSize=8388608 -XX:MinRAMPercentage=30.000000 -XX:NewSize=666894336 -XX:NonNMethodCodeHeapSize=7602480 -XX:NonProfiledCodeHeapSize=122027880 -XX:OldSize=1333788672 -XX:ProfiledCodeHeapSize=122027880 -XX:ReservedCodeCacheSize=251658240 -XX:+SegmentedCodeCache -XX:SoftMaxHeapSize=2801795072 -XX:+UseCompressedClassPointers -XX:+UseCompressedOops -XX:+UseFastUnorderedTimeStamps -XX:+UseParallelGC 

screencapture-grafana-apps-gh-keycloak-a-5vel-p1-openshiftapps-d-basic-keycloak-dashboard-by-namespace-keycloak-perf-tests-2024-03-28-12_57_17

@kami619 kami619 requested a review from mhajas March 28, 2024 16:59
@kami619 kami619 marked this pull request as ready for review March 28, 2024 16:59
@ahus1 ahus1 merged commit 9c852a2 into keycloak:main Mar 29, 2024
3 checks passed
@kami619 kami619 deleted the is-744-argon2-hashing-changes branch April 1, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change to Argon2 password hashing
2 participants