Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restart pods after dataset is created in rosa scaling benchmark for scheduled and on demand runs #776

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

kami619
Copy link
Contributor

@kami619 kami619 commented Apr 16, 2024

  • I tried to do this with Keycloak CRD and annotating the restart time, but it was not working, hence fell back to using the reliable delete all pods method.

@kami619 kami619 force-pushed the is-improv-rosa-scaling-benchmark branch from 30221ee to c5ad16c Compare April 16, 2024 16:47
@kami619
Copy link
Contributor Author

kami619 commented Apr 16, 2024

@kami619 kami619 force-pushed the is-improv-rosa-scaling-benchmark branch from c5ad16c to 7e03dd0 Compare April 18, 2024 12:27
@kami619
Copy link
Contributor Author

kami619 commented Apr 18, 2024

@ahus1 this should be good now for another review.

@ahus1
Copy link
Contributor

ahus1 commented Apr 18, 2024

@kami619 - thank you for the update. Do you have an example run in your repository with this change that you can link to?

@kami619
Copy link
Contributor Author

kami619 commented Apr 18, 2024

@kami619 - thank you for the update. Do you have an example run in your repository with this change that you can link to?

I ran it with changes forced into my fork's main.

https://github.com/kami619/keycloak-benchmark/actions/runs/8739686884/job/23981556406#step:15:46

that annoying thing with github where you cannot run with the branch on your fork but have to backport the changes to main to get a GHA run, is there any better way around it ?

@ahus1 ahus1 merged commit 82f0f7e into keycloak:main Apr 18, 2024
2 checks passed
@ahus1
Copy link
Contributor

ahus1 commented Apr 18, 2024

AFAIK you can choose your branch at least when you run the dispatch via the UI. Yes, still not the simplest thing.

@kami619 kami619 deleted the is-improv-rosa-scaling-benchmark branch April 18, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants