Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated ISPN Metrics calculation. #794

Merged
merged 1 commit into from
May 2, 2024
Merged

Updated ISPN Metrics calculation. #794

merged 1 commit into from
May 2, 2024

Conversation

andyuk1986
Copy link
Contributor

@andyuk1986 andyuk1986 commented May 2, 2024 •
edited by ahus1
Loading

Closes #636

@andyuk1986 andyuk1986 mentioned this pull request May 2, 2024
Closed
@ahus1
Copy link
Contributor

ahus1 commented May 2, 2024

@andyuk1986 - thank you for this PR. Did you run a test of this in your local repository, and can you please provide a link to the GitHub action run in this issue?

@ahus1 ahus1 self-requested a review May 2, 2024 10:48
@andyuk1986
Copy link
Contributor Author

@ahus1 yes, I have run it on my fork, here are the list of runs:
https://github.com/andyuk1986/keycloak-benchmark/actions/runs/8920475203 (is latest)
https://github.com/andyuk1986/keycloak-benchmark/actions/runs/8919949259

The numbers are ~the same between runs, so for memoryUsageTest is ~23ms, for cpuUsageForLoginsTest is ~11ms, for cpuUsageForCredentialGrantsTest is between 48-51ms.

ahus1
ahus1 approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for providing the links to the runs, they look good to me.

@ahus1 ahus1 merged commit 547f745 into keycloak:main May 2, 2024
2 checks passed
@ahus1
Copy link
Contributor

ahus1 commented May 2, 2024

It is interesting to see that those times are very different. Let's see how they behave on different days of the nightly run, and then see if there is a pattern. It would be good if you could keep that on your radar. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahus1 ahus1 ahus1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Horreum: Include latencies from Infinispan Metrics
2 participants
@andyuk1986 @ahus1