Exclude the Highcharts dependency and provide a minimal replacement #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to keycloak#809 Signed-off-by: Alexander Schwartz <[email protected]>
ahus1
force-pushed
the
remove-gatling-highcharts-dependency
branch
from
568328c
to
6d8f715
Compare
|
This is an example out, all charts will be gone:
This minimal replacement will continue to provide a See the ZIP file of a small example run here: result.zip |
|
@kami619 - I managed to remove the problematic library. The output is not so nice, but sufficient for our automatic nightly runs. I assume we would then need to rely more on the Grafana dashboards :-/ |
ryanemerson
reviewed
May 23, 2024
benchmark/src/main/resources/META-INF/services/io.gatling.charts.component.ComponentLibrary
Show resolved
Hide resolved
|
the changes look good to me, and thanks Alex for providing a functional replacement to high charts. I think we could live without the graphs, in the end even in the html charts, I was mostly following the numbers, which are still present. |
kami619
approved these changes
May 23, 2024
|
@ryanemerson feel free to review this further and merge it if you are satisfied as well. |
|
Thanks @ahus1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #809